[mdns]: Fixes clang-tidy warnings #732
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cermak
force-pushed
the
fix/mdns_clangtiy_warns
branch
from
ddb4b36 to
e37b8a6
Compare
|
@zwx1995esp PTAL, too |
zwx1995esp
approved these changes
Jan 15, 2025
components/mdns/mdns.c
Outdated
| @@ -5346,7 +5351,7 @@ static void _mdns_service_task(void *pvParameters) | |||
| for (;;) { | |||
| if (_mdns_server && _mdns_server->action_queue) { | |||
| if (xQueueReceive(_mdns_server->action_queue, &a, portMAX_DELAY) == pdTRUE) { | |||
| if (a && a->type == ACTION_TASK_STOP) { | |||
| if (a == NULL || a->type == ACTION_TASK_STOP) { | |||
There was a problem hiding this comment.
Question: does a == NULL mean that an exception occurs? If yes, at this time, should we stop mdns timer? Should we free the lock and deinit the queue? How about asserting right now?
There was a problem hiding this comment.
It's definitely an invalid state, which should never happen -- i.e. typically happens during mem corrupt issues.
assert() is probably a better reaction then just stopping the task.
Have fixed, thanks for the suggestion!
We did check for null-deref before checking 'a->type', but contol continues and passes potential null-ptr to the processing function _mdns_execute_action() Fixed by asserting action != NULL, since it is an invalid state which should never happen.
Since it was flagged by clang-tidy as insecture API
Fixing: warning: Value stored to 'shared' is never read [clang-analyzer-deadcode.DeadStores]
and some minor leaks in creation of browse results
david-cermak
force-pushed
the
fix/mdns_clangtiy_warns
branch
from
e37b8a6 to
196198e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: